Fix patch_task_instance endpoint#50550
Merged
pierrejeambrun merged 1 commit intoapache:mainfrom May 14, 2025
Merged
Conversation
pierrejeambrun
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
pierrejeambrun
added
the
backport-to-v3-1-test
boring-cyborg
bot
added
area:API
pierrejeambrun
force-pushed
the
update-patch-task-instance-return-type
branch
from
5c447cf to
39cd8c7
Compare
bbovenzi
approved these changes
May 13, 2025
bugraoz93
approved these changes
May 13, 2025
jason810496
approved these changes
May 14, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks!
Follow up:
I think we can extract the map_index query parameter into a common parameter class to handle the logic:
map_index = -1 if map_index is None else map_index directly in the router.
I'll raise a follow-up PR after this one is merged.
Member
Author
|
This was just to limit the PR to the change spec, but with #50526 this lines won't exist anymore. (None will be handled as summary) |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker db89cc0 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
May 14, 2025
(cherry picked from commit db89cc0)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
May 14, 2025
(cherry picked from commit db89cc0)
pierrejeambrun
added a commit
that referenced
this pull request
May 14, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update spec for the
patch_task_instance_endpoint. This is necessary to be able to handle in the future task instance summaries (all the map_indexes for a given TI) and task groups.This fell through the cracks and need to be fixed.